Conversation
…ferStatusLow call This can very quickly start to log lots of warnings.
🦋 Changeset detectedLatest commit: 1e97f7c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
Contributor
Author
|
I ran the end to end tests, and got a few failures which looked to be just flaky tests. So I don't think this broke anything. |
lukasIO
approved these changes
Apr 19, 2026
This was referenced Apr 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
waitForBufferStatusLowmethod of RTCEngine, a bunch of this.once calls are currently being made to listen forRTCEngineClosingevents. This can result potentially in errors like the below ifwaitForBufferStatusLowis called at a high rate (the below was captured in firefox, fwiw):While this seems to have been a problem in theory for a while, the recent shift to listening to
bufferedamountlowevents in #1877 rather thanawait sleep(10)in a loop I think has made this inadvertently worse, as thesleeps previously were giving the listeners time to drain and keeping the RtcEngine listener count below the threshold.So instead, listen once and fan out that single event to all in flight
waitForBufferStatusLowcalls.