Ignore data track promise rejections after a subscription readable stream is discarded#1917
Open
Ignore data track promise rejections after a subscription readable stream is discarded#1917
Conversation
…le stream is discarded
🦋 Changeset detectedLatest commit: d9e9c4a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
xianshijing-lk
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
track.subscribe({ signal })is called and the signal is aborted,IncomingDataTrackManager.openSubscriptionStreamrejects two things with the sameDataTrackSubscribeError:ReadableStream(catchable viatry/catch)sfuSubscriptionCompletepromise, used primarily in the tests, but also used during the brief window before the sfu subscription is established to communicate errors back to the user.Because
RemoteDataTrack.subscribe()returns only the stream and discards the promise, no handler was ever attached to thesfuSubscriptionCompletepromise, which meant that any rejections becomeunhandledRejections.This pull request works around this by adding a no-op
.catch(() => {})to this promise to silence any errors.