Skip to content

Bump tract-onnx from 0.22.1 to 0.22.3 in the cargo group across 1 directory #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump tract-onnx from 0.22.1 to 0.22.3 in the cargo group across 1 directory #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 92 additions & 37 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ parking_lot = "0.12"
prost = "0.14"
prost-build = "0.14"
prost-types = "0.14"
rand = "0.9"
rand = "0.10"

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing changeset file for dependency version bump

No changeset was added for this dependency upgrade (Cargo.toml:76), violating the repository's mandatory changeset requirement.

Impact: The PR cannot be merged according to repository contribution rules without a changeset documenting the change.

AGENTS.md changeset requirement

AGENTS.md states under "Documenting changes":

  • "Every PR needs a changeset"
  • "Changeset must list any crates which need to be bumped stemming from the change"
  • "Document changes interactively from the CLI with knope document-change or create manually in /.changeset"

The PR bumps rand from 0.9 to 0.10 in the workspace dependencies, which affects livekit-api, livekit-datatrack, and several example crates. No corresponding changeset file was created in the /.changeset directory.

Prompt for agents 
A changeset file needs to be created in the .changeset/ directory documenting this rand version bump. Run knope document-change from the CLI or manually create a markdown file in .changeset/ that lists the affected crates (livekit-api, livekit-datatrack, and any example crates that depend on rand) and describes the rand 0.9 to 0.10 upgrade.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Multiple rand versions now coexist in the dependency tree

After this bump, the Cargo.lock shows three versions of rand in the tree: 0.8.5 (transitive, pre-existing), 0.9.4 (used by fake and quinn-proto), and 0.10.2 (workspace crates). The livekit-datatrack crate implements fake::Dummy trait methods with bounds like R: rand::Rng + ?Sized (livekit-datatrack/src/packet/time.rs:120, livekit-datatrack/src/packet/handle.rs:90, livekit-datatrack/src/packet/mod.rs:70). Since fake depends on rand 0.9.4 and livekit-datatrack now resolves rand to 0.10.2, the Rng trait from these two versions are distinct types, which could cause trait mismatch issues in the Dummy implementations.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

serde = "1"
serde_json = "1.0"
thiserror = "2"
Expand Down
Loading