fix: don't log expected publisher data channel close as unexpected#1224
Open
longcw wants to merge 2 commits into
Open
fix: don't log expected publisher data channel close as unexpected#1224longcw wants to merge 2 commits into
longcw wants to merge 2 commits into
Conversation
When the server tears a session down (e.g. the room is deleted) it closes the publisher data channels from the remote side before the engine sets its own `closed` flag, so the close was logged at ERROR as "publisher data channel closed unexpectedly" even though it was expected.
Record the terminal disconnect (server `Leave{Disconnect}`) and skip the error for the close it triggers. Genuine unexpected closes — e.g. an oversized message silently killing the channel — still log, and Resume/Reconnect are unaffected.
Contributor
ChangesetThe following package versions will be affected by this PR:
|
Author
user disconnects using if !inner.closed.load(Ordering::Acquire)
&& !inner.disconnecting.load(Ordering::Acquire)
&& inner.publisher_pc.is_connected()
{
log::error!("publisher data channel '{}' closed unexpectedly", label);
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the spurious ERROR logs reported in livekit/agents#6250.
When the server tears a session down (e.g. the room is deleted) it closes the publisher data channels from the remote side before the engine sets its
closedflag, so the close was logged at ERROR as "publisher data channel closed unexpectedly" even though it was expected.This records the terminal disconnect (server
Leave{Disconnect}) so the close it triggers isn't logged as unexpected. Genuine unexpected closes (e.g. an oversized message silently killing the channel) still log, and Resume/Reconnect are unaffected.