This repository was archived by the owner on Dec 26, 2025. It is now read-only.
Open
Conversation
victorges
reviewed
Dec 15, 2025
Comment on lines
+254
to
+255
| if isinstance(timing_cache, (str, Path)) and not os.path.exists(timing_cache): | ||
| load_timing_cache = None |
There was a problem hiding this comment.
So we add a default value for the timing cache but if it's not created by something else we don't use it? Can you add instructions on how to use this timing cache? Ideally it should be completely transparent to the lib user (incl creating the cache and maybe not leaving any dangling files behind?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for instance: conv2d for shape 128 x 128 -- this doesnt need to searched for again as we have cache