Skip to content

refactor: extract table pagination into reusable component#527

Merged
ECWireless merged 4 commits intomainfrom
refactor/seperate-pagination-component
Feb 2, 2026
Merged

refactor: extract table pagination into reusable component#527
ECWireless merged 4 commits intomainfrom
refactor/seperate-pagination-component

Conversation

@rickstaa
Copy link
Member

@rickstaa rickstaa commented Feb 1, 2026

This pull request moves the table pagination logic into seperate component so it can be reused across the app. Needed for #457.

Move table pagination logic into seperate component so it can be reused
across the app.

Co-authored-by: roaring30s <okaaycrypto@gmail.com>
Copilot AI review requested due to automatic review settings February 1, 2026 16:28
@rickstaa rickstaa requested a review from ECWireless as a code owner February 1, 2026 16:28
@vercel
Copy link
Contributor

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
explorer-arbitrum-one Ready Ready Preview, Comment Feb 2, 2026 3:49pm

Request Review

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extracts table pagination logic into a reusable Pagination component to support future features requiring pagination outside of the DataTable context, particularly for the orchestrator voting activity UI being developed in PR #457.

Changes:

  • Created a new Pagination component that encapsulates pagination UI and logic
  • Refactored the DataTable component to use the new reusable Pagination component
  • Removed pagination-related icon imports from the Table component as they're now in the Pagination component

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
components/Table/Pagination.tsx New reusable pagination component with props for page state and navigation callbacks
components/Table/index.tsx Refactored to use the new Pagination component, simplifying the DataTable implementation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Feb 1, 2026

@rickstaa I've opened a new pull request, #528, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* fix: hide pagination when totalPages is 0

Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>

* Update components/Table/Pagination.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: rickstaa <17570430+rickstaa@users.noreply.github.com>
Co-authored-by: ECWireless <40322776+ECWireless@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ECWireless ECWireless merged commit 253eee3 into main Feb 2, 2026
7 checks passed
@ECWireless ECWireless deleted the refactor/seperate-pagination-component branch February 2, 2026 15:58
@github-project-automation github-project-automation bot moved this from In Review to Done in Explorer - Data Exposure Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants