feat: add persistent Apollo cache for proposal data#571
Open
rickstaa wants to merge 1 commit intofeat/apollo-cache-and-network-votesfrom
Open
feat: add persistent Apollo cache for proposal data#571rickstaa wants to merge 1 commit intofeat/apollo-cache-and-network-votesfrom
rickstaa wants to merge 1 commit intofeat/apollo-cache-and-network-votesfrom
Conversation
Persist the InMemoryCache to localStorage so previously fetched data (especially finished proposals) survives full page reloads. The app waits for cache restoration before rendering to avoid flicker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
|
|
||
| export * from "./subgraph"; | ||
|
|
||
| const cache = new InMemoryCache(); |
Contributor
There was a problem hiding this comment.
Apollo cache created at module load time as singleton, causing data leakage between SSR requests in the same Node.js process
| export function useApolloReady() { | ||
| const [ready, setReady] = useState(typeof window === "undefined"); | ||
| useEffect(() => { | ||
| cachePersistPromise.then(() => setReady(true)); |
Contributor
There was a problem hiding this comment.
Suggested change
| cachePersistPromise.then(() => setReady(true)); | |
| cachePersistPromise | |
| .then(() => setReady(true)) | |
| .catch(() => setReady(true)); // Even if cache persistence fails, proceed with the app |
Missing error handling for cache persistence failure causes app to remain in loading state indefinitely when localStorage is unavailable
|
|
||
| /** Wait for the persisted cache to restore before rendering queries. */ | ||
| export function useApolloReady() { | ||
| const [ready, setReady] = useState(typeof window === "undefined"); |
Contributor
There was a problem hiding this comment.
Suggested change
| const [ready, setReady] = useState(typeof window === "undefined"); | |
| const [ready, setReady] = useState(false); |
useApolloReady hook causes hydration mismatch by initializing different state on server vs client
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apollo3-cache-persist(compatible with current Apollo Client 3.13.1)InMemoryCachetolocalStorageso previously fetched data (especially finished proposals) survives full page reloadsmaxSizeto preventlocalStoragebloatStack
This is part of a stacked PR chain:
feat/improve-treasury-votes-caching-behavior— ENS cachingfeat/ens-cache-improvements— remove redundant localEnsCache + add TTLfeat/apollo-cache-and-network-votes— Apollo fetch policy for vote datafeat/apollo-persistent-cache— persistent Apollo cache via localStorageTest plan
localStoragecontains Apollo cache data (check in DevTools > Application > Local Storage)🤖 Generated with Claude Code