[DO NOT MERGE] test: live runner logs + slog -v bridge#3945
Closed
rickstaa wants to merge 2 commits into
Closed
Conversation
Add slog lifecycle logging for dynamic and static runners: registered, deregistered (reason: "heartbeat timeout" / "unregister"), static health changes (ready <-> unavailable), and price set (slog.Debug, on change only). The rest are slog.Info.
slog (used by the live runner registry, trickle, ai/worker, and media) ran at its default Info level with no way to enable Debug, so every slog.Debug line was dropped regardless of -v. Enable slog Debug at -v 6 (the documented max verbosity) so the existing flag also controls slog output.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway / do-not-merge. Combines PR #3943 (live runner lifecycle logs) and PR #3944 (slog→
-vbridge) on top ofja/live-runnerso CI builds a single test image (pr-<this>) where theslog.Debugprice line is actually reachable at-v 6. Used only to validate the logs end-to-end in the example-apps stack; will be deleted after testing.-v