Skip to content

fix: compare poll endBlock against L1 block number instead of L2 on Arbitrum #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rickstaa wants to merge 1 commit into from
Closed

fix: compare poll endBlock against L1 block number instead of L2 on Arbitrum #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/mappings/pollTallyHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,15 @@ export function updatePollTallyOnReward(event: Reward): void {
let poll = Poll.load(pollAddress);

// Return if poll is no longer active
if (!poll || poll.endBlock.lt(event.block.number)) {
// Use getBlockNum() (L1 block number) instead of event.block.number (L2 block
// number) since poll.endBlock is set from the contract's block.number which
// returns L1 block numbers on Arbitrum
let blockNum = getBlockNum();
if (!poll || poll.endBlock.lt(blockNum)) {
return;
}

let round = createOrLoadRound(getBlockNum());
let round = createOrLoadRound(blockNum);
let voteId = makeVoteId(delegator.id, poll.id);
let vote = createOrLoadVote(voteId);
let transcoder = createOrLoadTranscoder(
Expand Down Expand Up @@ -82,7 +86,10 @@ export function updatePollTallyOnBond(event: Bond): void {
let poll = Poll.load(pollAddress);

// Return if poll is no longer active
if (!poll || poll.endBlock.lt(event.block.number)) {
// Use getBlockNum() (L1 block number) instead of event.block.number (L2 block
// number) since poll.endBlock is set from the contract's block.number which
// returns L1 block numbers on Arbitrum
if (!poll || poll.endBlock.lt(getBlockNum())) {
return;
}

Expand Down Expand Up @@ -209,11 +216,15 @@ function updatePollTally<T extends Rebond>(event: T): void {
let updateTally = false;

// Return if poll is no longer active
if (!poll || poll.endBlock.lt(event.block.number)) {
// Use getBlockNum() (L1 block number) instead of event.block.number (L2 block
// number) since poll.endBlock is set from the contract's block.number which
// returns L1 block numbers on Arbitrum
let blockNum = getBlockNum();
if (!poll || poll.endBlock.lt(blockNum)) {
return;
}

let round = createOrLoadRound(getBlockNum());
let round = createOrLoadRound(blockNum);
let voterAddress = dataSource.context().getString("voter");
let voteId = makeVoteId(voterAddress, pollAddress);
let vote = createOrLoadVote(voteId);
Expand Down