[fix] parse: fix reviver not recursing into nested objects#5
Merged
ljharb merged 1 commit intoljharb:mainfrom Apr 15, 2026
Conversation
The walk function in the reviver implementation was iterating over the 'value' function instead of 'val' (the current object node). This prevented the reviver from being called for nested properties. Changed: for (k in value) to for (k in val) This ensures the reviver function is properly called for all nested objects and arrays, matching the behavior of native JSON.parse. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
ljharb
force-pushed
the
deepview/75a90de18cb45870a391e1825adbb8136307dccdafc2ee9126d0da4a618be35c
branch
from
7d9131e to
3c90840
Compare
ljharb
approved these changes
Apr 15, 2026
ljharb
force-pushed
the
deepview/75a90de18cb45870a391e1825adbb8136307dccdafc2ee9126d0da4a618be35c
branch
2 times, most recently
from
ba2b26e to
a4adae6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The walk function in the reviver implementation was iterating over the
'value' function instead of 'val' (the current object node). This prevented
the reviver from being called for nested properties.
Changed: for (k in value) to for (k in val)
This ensures the reviver function is properly called for all nested objects
and arrays, matching the behavior of native JSON.parse.