Test#12
Conversation
AI-assisted: prepared with Codex by OpenAI
AI-assisted: prepared with Codex by OpenAI
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
lkhorasandzhian
added
develop
lkhorasandzhian
left a comment
lkhorasandzhian
left a comment
There was a problem hiding this comment.
Everything is good. Ready to merge!
|
@self-approval /approve |
![self-approval[bot]](https://avatars.githubusercontent.com/in/227322?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ec4e8b9bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Set-Alias -Name line-counter -Value Get-LineCount -Option AllScope | ||
| Set-Alias -Name super-counter -Value Get-CodeStats -Option AllScope | ||
| Set-Alias -Name tree-color -Value Show-ColorTree -Option AllScope | ||
| Set-Alias -Name ll -Value Get-ChildItem -Scope Global -Option AllScope |
There was a problem hiding this comment.
Using Set-Alias ... -Scope Global here forces aliases into the global session even when callers intentionally use Import-Module -Scope Local. In that scenario, aliases like la/file-counter leak outside the caller’s scope and can shadow existing commands for the rest of the session, which breaks normal module scoping behavior. Keep aliases module-scoped and export them through module exports instead of hard-coding global scope.
Useful? React with 👍 / 👎.
| 'super-counter', | ||
| 'tree-color' | ||
| ) | ||
| AliasesToExport = @() |
There was a problem hiding this comment.
Setting AliasesToExport to an empty array removes alias metadata from module discovery, so alias names are no longer advertised as exported commands. In a fresh session this breaks alias-based module autoload (for example, calling file-counter won’t trigger loading this module), which is a regression from the prior behavior where legacy aliases were exported.
Useful? React with 👍 / 👎.
2 participants
Minor fix with legacy names.