[Feature] wire the datalayer plugins into the configuration #136
Open
ronenkat wants to merge 28 commits into
Open
[Feature] wire the datalayer plugins into the configuration #136ronenkat wants to merge 28 commits into
ronenkat wants to merge 28 commits into
Conversation
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
|
Your PR is large. Please consider breaking it into multiple PRs. The |
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
shmuelk
reviewed
May 28, 2026
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
shmuelk
reviewed
May 28, 2026
Signed-off-by: ronenkat <16743404+ronenkat@users.noreply.github.com>
Collaborator
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Replaces the hardcoded
NotificationSourceincmd/runner/runner.gowith aconfig-driven approach. Users now declare notification-source plugins in the
pluginssection and list them under a new top-level
notificationSourcesfield in thePayloadProcessorConfig. The runner starts each configured source via thecontroller-runtime manager, which guarantees
Stop()is called on graceful shutdown.Changes:
apix/config/v1alpha1: addedNotificationSources []PluginReffield toPayloadProcessorConfig(and updated generated DeepCopy)pkg/config: addedNotificationSources []datasource.NotificationSourcetoConfigpkg/config/loader: addedbuildDatalayercalled afterbuildProfiles; resolvesplugin refs and type-asserts each to
NotificationSourceinternal/runnable: newDataSourceRunnableadapter that starts aDataSource,blocks until context cancellation, then calls
Stop()cmd/runner:loadConfigurationnow returns*config.Config; replaces hardcodedblock with a loop that registers each source with the manager
deploy/config/ipp-datalayer-config.yaml: example config wiring a notification-sourcewith a request-metadata extractor
Which issue(s) this PR fixes:
Fixes #135
Release note (write
NONEif no user-facing change):