Skip to content

AMS dependencies are now linked in as private#42

Draft
koparasy wants to merge 2 commits intodevelopfrom
features/integration
Draft

AMS dependencies are now linked in as private#42
koparasy wants to merge 2 commits intodevelopfrom
features/integration

Conversation

@koparasy
Copy link
Member

No description provided.

@koparasy koparasy requested a review from rblake-llnl January 25, 2024 01:46
@rblake-llnl
Copy link
Member

Giving it a try before lunch, I should have outcomes by the meeting.

@rblake-llnl
Copy link
Member

Mods needed for me to compile:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fbeea1e..4e7bd02 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -130,9 +130,9 @@ endif() # WITH_REDIS
 if (WITH_HDF5)
   find_package(HDF5 NAMES hdf5 COMPONENTS C shared REQUIRED NO_DEFAULT_PATH PATHS ${HDF5_Dir} ${HDF5_Dir}/share/cmake)
   list(APPEND AMS_APP_INCLUDES ${HDF5_INCLUDE_DIR})
-  list(APPEND AMS_APP_LIBRARIES ${HDF5_C_SHARED_LIBRARY})
+  list(APPEND AMS_APP_LIBRARIES ${HDF5_LIBRARIES})
   list(APPEND AMS_APP_DEFINES "-D__ENABLE_HDF5__")
-  message(STATUS "HDF5 Shared Library: ${HDF5_C_SHARED_LIBRARY}")
+  message(STATUS "HDF5 Shared Library: ${HDF5_LIBRARIES}")
   message(STATUS "HDF5 Include directories: ${HDF5_INCLUDE_DIR}")
 endif() # WITH_HDF5

@@ -182,7 +182,7 @@ if (WITH_TORCH)
   find_package(Torch REQUIRED)
   # This is annoying, torch populates all my cuda flags
   # and resets them
-  set(CMAKE_CUDA_FLAGS "")
+  #set(CMAKE_CUDA_FLAGS "")
   set(CMAKE_CUDA_ARCHITECTURES ON)

   list(APPEND AMS_APP_INCLUDES "${TORCH_INCLUDE_DIRS}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants