Conversation
adayton1
reviewed
Apr 6, 2026
| # function returns TRUE if we are within a CPX allocation | ||
| # ############################################################################################################################## | ||
| def within_cpx_allocation(self): | ||
| command = ["/opt/rocm-6.4.1/bin/rocm-smi", "--showcomputepartition"] |
Member
There was a problem hiding this comment.
Should this also be updated? Or avoid being hardcoded?
Collaborator
There was a problem hiding this comment.
Maybe in a future change it can be plumbed in but it is ambiguous whether this should best be done using an environment variable or an ATS option, but this just needs to be present on the system for this to work. Note that the usage for our code doesn't rely on this (we pass --cpx directly).
adayton1
approved these changes
Apr 6, 2026
liu15
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen on CTS 2 machines using flux.