add in simple exciter code

.clang-tidy

@@ -11,6 +11,7 @@ google-*,
 modernize*,
 -modernize-use-trailing-return-type,
 -modernize-use-override,
+-modernize-use-ranges,
 -modernize-avoid-c-arrays,
 -modernize-pass-by-value,
 -modernize-use-equals-default,
@@ -24,11 +25,14 @@ hicpp-*,
 clang-analyzer-*,
 bugprone-*,
 -bugprone-narrowing-conversions,
+-bugprone-easily-swappable-parameters,
 misc-*,
 -misc-non-private-member-variables-in-classes,
+-misc-include-cleaner,
 cert-*,
 -cert-err58-cpp,
 portability-*,
+-portability-template-virtual-member-function,
 readability-*,
 -readability-magic-numbers,
 performance-*
@@ -45,6 +49,7 @@ google-*,
 modernize*,
 -modernize-use-trailing-return-type,
 -modernize-use-override,
+-modernize-use-ranges,
 -modernize-use-using,
 -modernize-avoid-c-arrays,
 -modernize-pass-by-value,
@@ -65,6 +70,7 @@ misc-*,
 cert-*,
 -cert-err58-cpp,
 portability-*,
+-portability-template-virtual-member-function,
 readability-*,
 -readability-magic-numbers,
 -readability-identifier-naming,
@@ -74,7 +80,6 @@ performance-*
 
 HeaderFilterRegex: 'src/helics/*.hp?p?'
 
-AnalyzeTemporaryDtors: false
 CheckOptions:
   - key:             cert-dcl59-cpp.HeaderFileExtensions
     value:           h,hh,hpp,hxx
@@ -315,7 +320,7 @@ CheckOptions:
   - key:             readability-identifier-naming.MethodSuffix
     value:           ''
   - key:             readability-identifier-naming.NamespaceCase
-    value:           lowercase
+    value:           lower_case
   - key:             readability-identifier-naming.NamespacePrefix
     value:           ''
   - key:             readability-identifier-naming.NamespaceSuffix

.github/actions/run-clang-tidy-pr.sh

@@ -1,4 +1,6 @@
 #!/bin/bash
+set -euo pipefail
+
 FILES_URL="$(jq -r '.pull_request._links.self.href' "$GITHUB_EVENT_PATH")/files"
 FILES=$(curl -s -X GET -G "$FILES_URL" | jq -r '.[] | .filename')
 echo "====Files Changed in PR===="
@@ -12,10 +14,25 @@ if ((filecount > 0 && filecount <= 20)); then
     cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DGRIDDYN_BUILD_C_SHARED_LIBRARY=ON ..
     cd ..
     echo "====Run clang-tidy===="
+    if [[ -x /usr/bin/run-clang-tidy ]]; then
+        TIDY_CMD=(/usr/bin/run-clang-tidy)
+    elif command -v run-clang-tidy >/dev/null 2>&1; then
+        TIDY_CMD=(run-clang-tidy)
+    elif command -v clang-tidy >/dev/null 2>&1; then
+        TIDY_CMD=(clang-tidy)
+    elif [[ -f /usr/share/clang/run-clang-tidy.py ]]; then
+        TIDY_CMD=(python3 /usr/share/clang/run-clang-tidy.py)
+    else
+        echo "clang-tidy helper not found in PATH and /usr/share/clang/run-clang-tidy.py is unavailable"
+        exit 2
+    fi
     while read -r line; do
         if echo "$line" | grep -E '\.(cpp|hpp|c|h)$'; then
-            python3 /usr/share/clang/run-clang-tidy.py "$line" -p build -quiet
-            rc=$?
+            if "${TIDY_CMD[@]}" -p build -quiet "$line"; then
+                rc=0
+            else
+                rc=$?
+            fi
             echo "clang-tidy exit code: $rc"
             if [[ "$rc" != "0" ]]; then
                 tidyerr=1

.github/workflows/braid-build.yml

@@ -3,12 +3,10 @@ name: Braid Build
 on:
   push:
     branches:
-      - develop
-      - modernization
+      - main
   pull_request:
     branches:
-      - develop
-      - modernization
+      - main
   workflow_dispatch:
 
 concurrency:

.github/workflows/ci-tests.yml

@@ -3,12 +3,10 @@ name: CI Tests
 on:
   push:
     branches:
-      - develop
-      - modernization
+      - main
   pull_request:
     branches:
-      - develop
-      - modernization
+      - main
   workflow_dispatch:
 
 concurrency:

.github/workflows/compiler-tests.yml

@@ -3,12 +3,10 @@ name: Compiler Tests
 on:
   push:
     branches:
-      - develop
-      - modernization
+      - main
   pull_request:
     branches:
-      - develop
-      - modernization
+      - main
   workflow_dispatch:
 
 concurrency:

.github/workflows/static-analyzers.yml

@@ -1,7 +1,13 @@
 name: Static Analyzers
 
 on:
+  push:
+    branches:
+      - main
   pull_request:
+    branches:
+      - main
+  workflow_dispatch:
 
 jobs:
   cpplint:

config/cmake/FindSuiteSparse.cmake

@@ -403,11 +403,13 @@ macro(SuiteSparse_FIND_COMPONENTS)
             set(SuiteSparse_${suitesparseCompUC}_FOUND OFF)
         else()
             set(SuiteSparse_${suitesparseCompUC}_FOUND ON)
-            set_target_properties(
-                ${SuiteSparseNameSpace}::${suitesparseCompLC}
-                PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
-                           "${SuiteSparse_${suitesparseCompUC}_INCLUDE_DIR}"
-            )
+            if(SuiteSparse_${suitesparseCompUC}_INCLUDE_DIR)
+                set_target_properties(
+                    ${SuiteSparseNameSpace}::${suitesparseCompLC}
+                    PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
+                               "${SuiteSparse_${suitesparseCompUC}_INCLUDE_DIR}"
+                )
+            endif()
         endif()
 
         # if one or both (include dir or filepath lib), then we provide a new cmake cache variable

config/cmake/updateGitSubmodules.cmake

@@ -26,15 +26,17 @@ macro(submod_update_all)
     if(ENABLE_SUBMODULE_UPDATE)
         message(STATUS "Git Submodule Update")
         execute_process(
-            COMMAND ${GIT_EXECUTABLE} submodule update --init
-            WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+            COMMAND ${GIT_EXECUTABLE} -c safe.directory=${PROJECT_SOURCE_DIR} submodule update
+                    --init
+            WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
             RESULT_VARIABLE GIT_RESULT
             OUTPUT_VARIABLE GIT_OUTPUT
+            ERROR_VARIABLE GIT_ERROR
         )
         if(GIT_RESULT)
             message(
                 WARNING
-                    "Automatic submodule checkout with `git submodule --init` failed with error ${GIT_RESULT} and output ${GIT_OUTPUT}. Checkout the submodules before building."
+                    "Automatic submodule checkout with `git submodule --init` failed with error ${GIT_RESULT} and output ${GIT_OUTPUT}${GIT_ERROR}. Checkout the submodules before building."
             )
         endif()
     else()
@@ -46,15 +48,17 @@ macro(submod_update target)
     if(ENABLE_SUBMODULE_UPDATE)
         message(STATUS "Git Submodule Update ${target}")
         execute_process(
-            COMMAND ${GIT_EXECUTABLE} submodule update --init -- ${target}
-            WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
+            COMMAND ${GIT_EXECUTABLE} -c safe.directory=${PROJECT_SOURCE_DIR} submodule update
+                    --init -- ${target}
+            WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
             RESULT_VARIABLE GIT_RESULT
             OUTPUT_VARIABLE GIT_OUTPUT
+            ERROR_VARIABLE GIT_ERROR
         )
         if(GIT_RESULT)
             message(
                 WARNING
-                    "Automatic submodule checkout with `git submodule --init -- $[target}` failed with error ${GIT_RESULT} and output ${GIT_OUTPUT}. Checkout the submodules before building."
+                    "Automatic submodule checkout with `git submodule --init -- ${target}` failed with error ${GIT_RESULT} and output ${GIT_OUTPUT}${GIT_ERROR}. Checkout the submodules before building."
             )
         endif()
     else()