Open
Conversation
Collaborator
Author
|
Found a failure case. Hold off on review for now. |
rountree
requested a deployment
to
Spindle CI
GitHub Actions
In progress
rountree
had a problem deploying
to
Spindle CI
GitHub Actions
Failure
rountree
had a problem deploying
to
Spindle CI
GitHub Actions
Failure
rountree
had a problem deploying
to
Spindle CI
GitHub Actions
Failure
Unlikely it would ever make a difference, but this is much more correct.
src/client/beboot/spindle_bootstrap.c
Moved orig_location from static global to local
Renamed symbolic_location to symbolic_commpath
Renamed orig_location to orig_commpath
Renamed location to commpath
Renamed LDCS_LOCATION to LDCS_COMMPATH
src/client/client/client.c
Renamed LDCS_LOCATION to LDCS_COMMPATH
Renamed location to commpath
src/client/client_comlib/client_api.c
Added setenv("LDCS_CHOSEN_PARSED_CACHEPATH", local_cpc);
testsuite/test_driver.c
Replaced LDCS_LOCATION and LDCS_ORIG_LOCATION checks for cachepath with
LDCS_CHOSEN_PARSED_CACHEPATH
Replaced spindle_loc with cachepath
All tests pass with both distinct and identical commpaths/cachepaths.
Additionally populates /etc/environment just in case ssh is used to set up the servers.
rountree
had a problem deploying
to
Spindle CI
GitHub Actions
Failure
The option is marked as obsolete in configure --help and will cause an error in configure if it is specified. As updates the CI configure scripts to use --with-cachepaths and --with-commpath instead of --with-localstorage.
Replaces args->location with args->commpath.
TMPDIR left out of a docker script, and --cachepath instead of --cachepaths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
locationenvironment variables, fields, and enums tocommpath.Builds with --with-rm=[flux|serial|slurm]. Can't build slurm-plugin, but that's not due to these changes.