Skip to content

Fetch raw github repository config#156

Merged
alecbcs merged 3 commits into
llnl:mainfrom
cmelone:add/github-raw-content
Jul 8, 2025
Merged

Fetch raw github repository config#156
alecbcs merged 3 commits into
llnl:mainfrom
cmelone:add/github-raw-content

Conversation

@cmelone

@cmelone cmelone commented Jul 8, 2025

Copy link
Copy Markdown
Member

Rather than fetching base64-encoded file contents and decoding it ourselves, request the raw text of the config file available in the github repository. This aligns with the approach used in #145.

Rather than fetching base64-encoded json and decoding it ourselves,
request the raw text of the config file available in the github
repository. This aligns with the approach used in llnl#145.
@cmelone cmelone requested a review from alecbcs July 8, 2025 22:29
Comment thread src/hubcast/clients/github/client.py Outdated

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@alecbcs alecbcs merged commit d5a9ce7 into llnl:main Jul 8, 2025
4 checks passed
@cmelone cmelone deleted the add/github-raw-content branch August 25, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants