Skip to content

Unit tests#216

Open
cmelone wants to merge 49 commits into
llnl:mainfrom
cmelone:add/unit-tests
Open

Unit tests#216
cmelone wants to merge 49 commits into
llnl:mainfrom
cmelone:add/unit-tests

Conversation

@cmelone

@cmelone cmelone commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds unit tests for Hubcast. The goal of these tests is not to evaluate the end-to-end functionality of Hubcast, but to ensure that our business logic stays consistent.

Subsequent PRs will include integration tests to ensure that the input/output format of external APIs does not impact live Hubcast users. For example, the GitHub and GitLab clients under src/clients and the app entrypoint (src/__main__.py) will be covered as integration tests.

complete:

  • GitHub route handlers
  • account map logic
  • repo configuration
  • token cache (abstractly, no integration with GH/GL)

TODO:

  • app configuration (env variable getting, not going to test the config classes)
  • GitHub handler/spawning logic
  • GitLab route handlers
  • GitLab handler/spawning logic
  • LDAP account map
  • Add CI coverage check #218
  • if any PRs are merged before this, make sure they're covered in these tests

run a local coverage report:

coverage run --source=src -m pytest tests && coverage html

@github-actions github-actions Bot added the dependencies Modifications to a Dependency File label Jan 22, 2026
cmelone
cmelone commented Jan 22, 2026
View reviewed changes
Comment thread tests/test_repo_config.py
@cmelone cmelone requested a review from alecbcs January 22, 2026 01:02
@github-actions github-actions Bot added the ci Involving Project CI & Unit Tests label Jan 22, 2026
@cmelone cmelone added the tests Modifications to App Unit Tests label Jan 22, 2026
@cmelone cmelone force-pushed the add/unit-tests branch 2 times, most recently from 7eab20c to ffd946a Compare January 22, 2026 16:55
@cmelone cmelone mentioned this pull request Jan 22, 2026
Open
@cmelone cmelone force-pushed the add/unit-tests branch 3 times, most recently from 0606c01 to 8b60a91 Compare March 11, 2026 22:55
@cmelone cmelone force-pushed the add/unit-tests branch 2 times, most recently from 3abb954 to 22eddf7 Compare March 25, 2026 00:03
alecbcs
alecbcs reviewed Apr 10, 2026
View reviewed changes
Comment thread src/hubcast/account_map/file.py Outdated
@cmelone cmelone force-pushed the add/unit-tests branch 5 times, most recently from cb54666 to e36297b Compare April 14, 2026 22:11
@cmelone cmelone force-pushed the add/unit-tests branch 2 times, most recently from e364242 to 66f5641 Compare May 20, 2026 17:19
@cmelone cmelone linked an issue May 22, 2026 that may be closed by this pull request
Add CI coverage check #218
Open
@cmelone cmelone force-pushed the add/unit-tests branch 3 times, most recently from 41397c6 to 9f1925f Compare May 26, 2026 23:45
alecbcs
alecbcs previously approved these changes Jun 1, 2026
View reviewed changes

@alecbcs alecbcs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple super small nitpicks, otherwise this PR looks good to me.

Comment thread .github/workflows/ci.yml
Comment thread spack/repos/spack_repo/hubcast/packages/py_hubcast/package.py Outdated
Comment thread spack/repos/spack_repo/hubcast/packages/py_hubcast/package.py Outdated
Comment thread spack/repos/spack_repo/hubcast/packages/py_hubcast/package.py Outdated
Comment thread spack/repos/spack_repo/hubcast/packages/py_hubcast/package.py Outdated
Comment thread src/hubcast/web/github/routes.py Outdated
cmelone and others added 28 commits June 12, 2026 11:07
@cmelone
update tests to accept new return value from get_repo_config
7cba895
@cmelone
default to hubcast spec with unit tests and ldap
6db3d52
@cmelone
update repo config tests
509106a
@cmelone
add test for delete_closed being respected
35bea66
@cmelone
fix tests/test_github_routes.py::test_sync_pr_skip_draft
3c3d48b
@cmelone
update for logging changes
b437232
@cmelone
style
a4038df
@cmelone
update tests for llnl#288
7e4e7d9
@cmelone
update app config tests
b2911a3
@cmelone
update tests for pydantic repo config
61ff8a0 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
fmt
04dd74b
@cmelone
update tests for ty check
274951d
@cmelone
fix routing token handling tests
f89b7e4
@cmelone
rebase fixes and pipeline relay changes
5dfb707 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
more coverage for GH routes
adad48f 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
need unit test workflow to run
5eb1bd4
@cmelone
misc config changes
d7dc26a 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
add coverage for github/gitlab handlers
0da8c80 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
tests for routing token
3e022b9 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
update tests for create mr and job status forwarding
94eed24 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
fmt
4ebeabd 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
fix failure in gitlab handler test
8792746 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
modify tests for recent commits
65d824a
@cmelone
capture log statements instead of return dicts
b078bae 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
capture logging events rather than event status
54fe9a0 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
fmt
ca41f55 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
tests for relaying jobs/ pipelines
8c65c82 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone @alecbcs
address review comments
14bd1a8 
Co-authored-by: Alec Scott <scott112@llnl.gov>
Signed-off-by: Caetano Melone <melone1@llnl.gov>
@cmelone
fmt
c66366c 
Signed-off-by: Caetano Melone <melone1@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alecbcs alecbcs alecbcs left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ci Involving Project CI & Unit Tests dependencies Modifications to a Dependency File tests Modifications to App Unit Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add CI coverage check

2 participants

@cmelone @alecbcs