Add config option to relay neutral status on jobs allowed to fail#345
Open
cmelone wants to merge 1 commit into
Open
Add config option to relay neutral status on jobs allowed to fail#345cmelone wants to merge 1 commit into
cmelone wants to merge 1 commit into
Conversation
If a job does not succeed and allow_failure is enabled in the job's GitLab definition, Hubcast will relay the job's GH status as "neutral," allowing the pipeline to succeed. Signed-off-by: Caetano Melone <melone1@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a job does not succeed and allow_failure is enabled in the job's GitLab definition, Hubcast will relay the job's GH status as "neutral," allowing the pipeline to succeed.
One thing I want to note is while we modify the title associated with the allowed to fail job indicating it was allowed to fail, the pipeline will only show success. We could change this to checking if any jobs in the pipeline were allowed to fail and all other succeeded, we'll post the pipeline status as neutral. Not sure what users would prefer.
Also, open to suggestions about the name of the config option.