Move the produced temporary generated files to a unique temp folder #336
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hmm I'm not sure why actions aren't running - lemme figure it out then we can merge (even though there aren't really "tests" for this path...) |
Member
Author
Thank you. Can just build it all and can query into Jupyterlite's filesystem and the generated binaries shouldn't be exposed no more and be present in a unique path. |
Contributor
Sure but I'm still not gonna merge without tests passing |
Member
Author
|
Yess offcourse no rush ;~) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem of exposing generated binaries as per pointed out here : https://discourse.llvm.org/t/mlir-python-bindings-entirely-in-the-browser/87013/4?u=anutosh491
We recently fixes it for clang-repl : llvm/llvm-project#175508 (comment)