workflows/release-binaries: Enable Windows x86 builds#128274
workflows/release-binaries: Enable Windows x86 builds#128274tstellar wants to merge 225 commits into
Conversation
8656c66 to
03222fc
Compare
|
@zmodem I've made some updates and now the configuration should match more closely to build_llvm_release.bat script. The main differences I know of are that the script enables openmp and this PR does not. Also, this PR is still using Wix instead of NSIS for the installer generator. I'm having a lot of trouble getting the build_llvm_release.bat script to run inside the github actions environment. Has anyone tried running it lately from the main branch where it builds the code from main and not code from a release? |
I just tried it, and yes there are a number of issues after @omjavaid's #131687 I suppose I should have tested it, not just reviewed it :-p (I build with Firstly For 64-bit, I'm still fiddling with this. It seems the arm64 packages solves this by not building the sanitizers and also not running the runtimes tests :) |
|
bcb3d2f lets me get through packaging of 21.1.4. Does that address the issues you were seeing? |
|
Thank you. I will test this and get back to you. |
|
@zmodem I'm seeing some errors building openmp, but I'm also building main using the Logs here: |
The first error is: I think I guess it somehow failed to generate the header, or at least didn't put it in the right place? Is it possible to run with higher cmake verbosity to see if/where it writes that file? Being paranoid: could there be some weird interaction between passing fwiw |
I think this fixed the OpenMP error. However, I'm starting to have problems with the python detection, but this seems like a change it's caused by a change in the GitHub environment recently and not with the script. |
This is meant to be a drop-in replacement for binaries built with the build_llvm_release.bat script, though the cmake configuration is slightly different. These builds also have flang and mlir which the script does not and it also enables all targets.