[Clang][AIX] Add -mloadtime-comment-vars flag to preserve identifying variables#187986
Draft
tonykuttai wants to merge 2 commits into
Draft
[Clang][AIX] Add -mloadtime-comment-vars flag to preserve identifying variables#187986tonykuttai wants to merge 2 commits into
tonykuttai wants to merge 2 commits into
Conversation
You can test this locally with the following command:git-clang-format --diff origin/main HEAD --extensions h,c,cpp -- clang/test/CodeGen/loadtime-comment-vars.c clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.h clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Transforms/Utils/LowerCommentStringPass.cpp --diff_from_common_commit
View the diff from clang-format here.diff --git a/llvm/lib/Transforms/Utils/LowerCommentStringPass.cpp b/llvm/lib/Transforms/Utils/LowerCommentStringPass.cpp
index 9a805ff7a..bbcb5a24e 100644
--- a/llvm/lib/Transforms/Utils/LowerCommentStringPass.cpp
+++ b/llvm/lib/Transforms/Utils/LowerCommentStringPass.cpp
@@ -170,7 +170,7 @@ PreservedAnalyses LowerCommentStringPass::run(Module &M,
auto *StrGV = new GlobalVariable(M, StrInit->getType(),
/*isConstant=*/true,
GlobalValue::WeakODRLinkage, StrInit,
- /*Name=*/ GlobalName);
+ /*Name=*/GlobalName);
StrGV->setUnnamedAddr(GlobalValue::UnnamedAddr::Global);
StrGV->setAlignment(Align(1));
// Backend recognizes this section and emits it to .loadtime_comment.
|
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) LLVMLLVM.LTO/PowerPC/pragma-comment-copyright-thinlto.llLLVM.Other/new-pm-thinlto-prelink-defaults.llLLVM.Other/new-pm-thinlto-prelink-pgo-defaults.llLLVM.Other/new-pm-thinlto-prelink-samplepgo-defaults.llClangClang.CodeGen/PowerPC/pragma-comment-copyright-modules.cppIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
tonykuttai
force-pushed
the
users/tonykuttai/pragma-comment-copyright-cli
branch
from
46d4ce4 to
aaf3e32
Compare
tonykuttai
changed the base branch from
users/tonykuttai/pragma-copyright-comment-update
to
users/tonykuttai/ltobugfix
tonykuttai
force-pushed
the
users/tonykuttai/pragma-comment-copyright-cli
branch
3 times, most recently
from
a31b969 to
268182a
Compare
in the final object file.
tonykuttai
force-pushed
the
users/tonykuttai/pragma-comment-copyright-cli
branch
from
268182a to
38146ce
Compare
…a-comment-copyright-cli
🪟 Windows x64 Test Results
Failed Tests(click on a test name to see its output) LLVMLLVM.LTO/PowerPC/pragma-comment-copyright-thinlto.llLLVM.Other/new-pm-thinlto-prelink-defaults.llLLVM.Other/new-pm-thinlto-prelink-pgo-defaults.llLLVM.Other/new-pm-thinlto-prelink-samplepgo-defaults.llClangClang.CodeGen/PowerPC/pragma-comment-copyright-modules.cppIf these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a new Clang command-line option,
-mloadtime-comment-vars=, which accepts a comma-separated list of variable names to preserve as loadtime identifying strings in the final binary object file.It ensures that these specific string variables (such as strings that embed 'sccsid' or 'version' info in source variables) are preserved in the object file and not stripped during aggressive garbage collection. This complements the
#pragma comment(copyright, ...)feature by supporting codebases that use this older pattern.This is a stacked pr on top of [Analysis][AIX] Add !implicit.ref globals as ThinLTO summary ref edges to support pragma comment(copyright) LTO interaction which in turn depends on [PowerPC][AIX] Support #pragma comment copyright for AIX.