Skip to content

[Mips] Remove mips from omitting the frame pointer for Linux#199381

Open
brad0 wants to merge 1 commit into
llvm:mainfrom
brad0:clang_mips_frame_pointer_linux
Open

[Mips] Remove mips from omitting the frame pointer for Linux#199381
brad0 wants to merge 1 commit into
llvm:mainfrom
brad0:clang_mips_frame_pointer_linux

Conversation

@brad0
Copy link
Copy Markdown
Contributor

@brad0 brad0 commented May 23, 2026

6b1f976 enabled omitting
the frame pointer no matter what OS so remove the now redundancy
with having this on the Linux path.

@brad0 brad0 requested a review from yingopq May 23, 2026 22:01
@llvmorg-github-actions llvmorg-github-actions Bot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels May 23, 2026
@llvmorg-github-actions
Copy link
Copy Markdown

llvmorg-github-actions Bot commented May 23, 2026

@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: Brad Smith (brad0)

Changes

6b1f976 enabled omitting
the frame no matter what OS so remove the now redundancy
with having this on the Linux path.


Full diff: https://github.com/llvm/llvm-project/pull/199381.diff

1 Files Affected:

  • (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (-4)
diff --git a/clang/lib/Driver/ToolChains/CommonArgs.cpp b/clang/lib/Driver/ToolChains/CommonArgs.cpp
index 2ef7c1506e18d..6a0dcfca62c60 100644
--- a/clang/lib/Driver/ToolChains/CommonArgs.cpp
+++ b/clang/lib/Driver/ToolChains/CommonArgs.cpp
@@ -121,10 +121,6 @@ static bool useFramePointerForTargetByDefault(const llvm::opt::ArgList &Args,
     case llvm::Triple::armeb:
     case llvm::Triple::thumb:
     case llvm::Triple::thumbeb:
-    case llvm::Triple::mips64:
-    case llvm::Triple::mips64el:
-    case llvm::Triple::mips:
-    case llvm::Triple::mipsel:
     case llvm::Triple::systemz:
     case llvm::Triple::x86:
     case llvm::Triple::x86_64:

6b1f976 enabled omitting
the frame pointer no matter what OS so remove the now redundancy
with having this on the Linux path.
@brad0 brad0 force-pushed the clang_mips_frame_pointer_linux branch from c863299 to fed738f Compare May 24, 2026 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant