Skip to content

[LifetimeSafety] Fix use-after-scope from #198784 #199455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thurstond merged 1 commit into from
May 24, 2026
+5 −2
Merged

[LifetimeSafety] Fix use-after-scope from #198784 #199455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clang/lib/Analysis/LifetimeSafety/Checker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,11 @@ class LifetimeChecker {

// We iterate in reverse order (from most recent to oldest) to find
// the first declaration in each file.
for (const FunctionDecl *Redecl :
llvm::reverse(llvm::to_vector(FDef->redecls())))

// Store in temporary variable to manually extend lifetime
auto redecls = llvm::to_vector(FDef->redecls());

for (const FunctionDecl *Redecl : llvm::reverse(redecls))
AddCrossTUDecl(Redecl);

return Targets;
Expand Down