Skip to content

fix: allow separate input/output budgets for T5 in context check #3885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chessing234 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix: allow separate input/output budgets for T5 in context check #3885

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fastchat/serve/openai_api_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,10 @@ async def check_length(request, prompt, max_tokens, worker_addr):
{"model": request.model, "prompt": prompt},
"count",
)
length = min(max_tokens, context_len - token_num)
is_enc_dec = "t5" in request.model.lower()
length = min(max_tokens, context_len if is_enc_dec else context_len - token_num)

if length <= 0:
if (is_enc_dec and token_num > context_len) or length <= 0:
return None, create_error_response(
ErrorCode.CONTEXT_OVERFLOW,
f"This model's maximum context length is {context_len} tokens. However, your messages resulted in {token_num} tokens. Please reduce the length of the messages.",
Expand Down
Loading