Skip to content

QLine parameters casted to int#17

Open
zsiki wants to merge 1 commit intolmotta:masterfrom
zsiki:master
Open

QLine parameters casted to int#17
zsiki wants to merge 1 commit intolmotta:masterfrom
zsiki:master

Conversation

@zsiki
Copy link
Copy Markdown

@zsiki zsiki commented Oct 18, 2022

On QGIS 3.26.3 with Qt 5.15.3 the call of QLine failed.

@zsiki
QLine parameters casted to int
10ba89b 
On QGIS 3.26.3 with Qt 5.15.3 the call of QLine failed.
@zsiki zsiki mentioned this pull request Oct 18, 2022
Open
julianzz98
julianzz98 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Copy Markdown

@julianzz98 julianzz98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a local test and can confirm that this fix is working. Thank you for the PR @zsiki!

@h-a-graham
Copy link
Copy Markdown

h-a-graham commented Jan 4, 2023

Fixes the issue for me also (Ubuntu 22.04, QGIS: 3.22.14) - many thanks!

@reidi
Copy link
Copy Markdown

reidi commented Jan 30, 2023

Also fixed the issue for me on latest Ubuntu Kinetic and QGIS Firenze - Ubuntu 22.10, QGIS 3.28.3 Hooray! Thanks!

@Paulovi
Copy link
Copy Markdown

Paulovi commented Mar 7, 2023

Great, it worked perfectly for me. (Pop!_OS 22.04, Qgis 3.22.13)

@lionlai1989
Copy link
Copy Markdown

lionlai1989 commented Apr 24, 2023 •
edited
Loading

This fix works for me. Can this PR be merged into the master?
My system info:
Ubuntu 20.04
QGIS 3.28

@saberraz
Copy link
Copy Markdown

saberraz commented May 25, 2023

This also works for me.
@lmotta could you please review, merge and push a new version to the QGIS plugins. It is affecting lots of users and failing to update your plugin, could risk a new fork.

cubarro
cubarro reviewed Feb 7, 2024
View reviewed changes
swipemap.py
Copy link
Copy Markdown

@cubarro cubarro Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That small change fixed the problem.
Thanks.

@jlaura
Copy link
Copy Markdown

jlaura commented May 24, 2024

Any change on a merge of this. Still broken in the released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@cubarro cubarro cubarro left review comments

@lupionpe lupionpe lupionpe approved these changes

@julianzz98 julianzz98 julianzz98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@zsiki @h-a-graham @reidi @Paulovi @lionlai1989 @saberraz @jlaura @cubarro @lupionpe @julianzz98