fix: wrong fiat calculations and retrieval#75
Merged
Conversation
dni
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix fiat withraw limits being converted in the wrong place.
The frontend was multiplying fiat min/max amounts before sending them to the API, but the backend already handles that normalization. That could save inflated values when updating an existing link.
The LNURL flow now uses the shared
min_max_withdrawable()helper when exposing withdraw limits and when validating callback invoice amounts. That keeps min/max handling consistent for both sat and fiat links, removes duplicated fiat conversion logic, and makes the min/max limits match the amount validation path.It also updates the
uvdev dependency config to the newer dependency group format and refreshes the lockfile.