ENG-296: Align ETH-USDT Cash Wallet receive path#344
Conversation
|
I created a Flash engineering review artifact for this PR. Full rendered artifact: https://htmlpreview.github.io/?https://github.com/lnflash/flash/blob/patoo0x/pr-344-review-artifact/docs/artifacts/pr-344/eth-usdt-cash-wallet-review.html Quick review takeaway: good direction, but I would not merge until the migration/address-ownership questions are closed. Critical / high-risk items to verify:
Note: I could not enable GitHub Pages on |
659098e to
21533d6
Compare
|
Closing this draft because ENG-296 is now marked duplicate/covered by ENG-276. Dread confirmed with Olaniran that ENG-276 includes the IBEX crypto receive webhook path, so we should keep this webhook/reconciliation surface owned by ENG-276 instead of landing a separate PR. |
Rebuilt on current
feature/bridge-integrationafter ENG-394 landed.ENG-296 is now narrowed to ETH-USDT Cash Wallet receive-path alignment. Wallet creation/defaulting is already handled by ENG-394, and Bridge virtual-account creation/query behavior is intentionally left to the dedicated Bridge VA tickets.
Changes:
crypto.receivewebhooks for Ethereum USDT (currency=USDT,network=ethereum)USDT/ethereumTests:
LOGLEVEL=warn ../../node_modules/.bin/jest --config ./test/flash/unit/jest.config.js --bail --verbose test/flash/unit/services/ibex/webhook-server/routes/crypto-receive.spec.tsgit diff --checktsc --noEmit -p tsconfig.d.json && tsc --noEmitstill fails on inherited baseline test/legacy-integration type errors unrelated to this PR.