Improve BO inj. optimzation class: posang & wait method#295
Draft
vellosok75 wants to merge 9 commits intomasterfrom
Draft
Improve BO inj. optimzation class: posang & wait method#295vellosok75 wants to merge 9 commits intomasterfrom
vellosok75 wants to merge 9 commits intomasterfrom
Conversation
- add `wait_set_pos` method - pos set to devices SP PVs directly - waits all RB vals reach SP vals after
vellosok75
requested review from
Copilot,
fernandohds564,
murilobalves and
xresende
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
apsuite/commisslib/injbo_optimize_rcds.py:670
- [nitpick] The timeout warning message is unclear; consider rephrasing it to 'Timed out waiting for positions to be set.'
_log.warning('Timed out waiting positions be set.')
Comment on lines
+574
to
+575
| self.wait_set_pos(pos, timeout=10, rtol=0.05, atol=0.1) | ||
|
|
There was a problem hiding this comment.
Unexpected keyword arguments 'rtol' and 'atol' passed to wait_set_pos; update the method call or the signature to match.
Suggested change
| self.wait_set_pos(pos, timeout=10, rtol=0.05, atol=0.1) | |
| self.wait_set_pos(pos, timeout=10, tol=0.05) |
Comment on lines
+650
to
+651
| """Wait positions RB reach the the desired SP vals. | ||
|
|
There was a problem hiding this comment.
There is a duplicated article 'the the' in the docstring; please remove one occurrence for clarity.
Suggested change
| """Wait positions RB reach the the desired SP vals. | |
| """Wait positions RB reach the desired SP vals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YET TO BE TESTED ONLINE!
wait_set_posmethod to guarantee RB values reach the desired SP when setting positions