Conversation
Contributor
anacso17
commented
Nov 4, 2025
- Add manual failure annotation for October 18th problem
- We had problems with PPS in this period (user shift without beam and with wrong machine shift annotations).
- Do not ignore wrong shift annotations in the beggining of an analized period
- There is a feature that was introduced to ignore wrong shift annotations within 1min (for example, to not indicate user shift problems if the MachShift mode PV changes in value 1min later than scheduled). This commit changes this feature to not ignore wrong shift annotations in the beggining of an analized period. This was causing a wrong indication of transition from "correct shift" to "wrong shift" when the analized period started with a wrong shift and, as a consequence, causing a wrong beam dump annotation.
- Update example of code to generate a report
We had problems with PPS in this period (user shift without beam and with wrong machine shift annotations).
… of an analized period There is a feature that was introduced to ignore wrong shift annotations within 1min (for example, to not indicate user shift problems if the MachShift mode PV changes in value 1min later than scheduled). This commit changes this feature to not ignore wrong shift annotations in the beggining of an analized period. This was causing a wrong indication of transition from "correct shift" to "wrong shift" when the analized period started with a wrong shift and, as a consequence, causing a wrong beam dump annotation.
xresende
approved these changes
Nov 5, 2025
Contributor
|
@anacso17 , did you notice that integration tests are failing? I looked at the output bu could not understand what is going on. maybe it is a temporary service instability? |
Contributor
Author
Hi @xresende , this is because of the fail in mathphys wheel build, which will be fixed with this PR lnls-fac/mathphys#37. |
fernandohds564
approved these changes
Nov 5, 2025
vellosok75
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.