A complete Persian (FA) translation and some minor corrections in the English file #711

RamzArzFarsi · 2025-12-12T19:14:42Z

The Persian translation file has weird phrasings and feels like a draft LLM translation.
This PR aims to replace it with a more refined and natural-sounding Persian translation done manually (no LLM is used).

Additionally, three minor mistakes were found in the English file along the way, which are also corrected by this PR.

Summary by CodeRabbit

Bug Fixes
- Updated buy flow to use /fiatsent command after Fiat payment and added seller-confirmation step before satoshis are sent.
- Corrected sell format guidance to properly indicate satoshis amount for the surplus parameter.
- Fixed image processing error message wording and formatting.

coderabbitai · 2025-12-12T19:14:53Z

Walkthrough

Updated the English localization file (locales/en.yaml): changed buy-flow follow-up command from /release to /fiatsent, added a seller-confirmation step before sats are sent, corrected sell guidance to reference sats for the surplus parameter, and made minor wording and newline/formatting adjustments (including image-processing error text).

Changes

Cohort / File(s)	Summary
Localization updates `locales/en.yaml`	Replaced `/release` with `/fiatsent` in buy-flow instructions and introduced a seller-confirmation step; corrected `surplus` description to indicate sats (not fiat); fixed wording/newline handling for image-processing and other messages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Update fa.yaml #707 — edits to localization strings (includes image_processing_error and trading-related keys) that overlap with these message changes.

Suggested reviewers

grunch

Poem

🐰 I nibbled text and hopped a beat,
Swapped a command and fixed a seat,
Sats now whisper where numbers stood,
A seller nod keeps flow in good,
Tiny hops, the messages sweet. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title describes adding a Persian translation and English corrections, but the raw_summary shows only minor English changes with no Persian file modifications.	Update the title to accurately reflect the actual changes shown in the diff, or ensure the Persian translation file changes are included in the pull request.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

✨ 136.113.208.247/32 (new)
34.170.211.100/32
35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

locales/en.yaml (1)

428-435: Template variable rename creates breaking change: code still passes id but en.yaml expects orderId.

The code in bot/messages.ts (line 1854) passes id: order._id to render pending_payment_success, but the en.yaml template now expects ${orderId}. This mismatch will cause the order ID to render blank for English users. Synchronize the parameter name in the code to orderId to match the template, or revert the template variable back to ${id}.

Note: Other locale files (it, pt, ru, ko, uk, es, fa, fr, de) still use ${id} in their pending_payment_success templates, so only en.yaml was changed. This inconsistency across locales should also be addressed.

🧹 Nitpick comments (2)

locales/en.yaml (2)
25-25: Clarify /fiatsent usage (with/without order id) to match the bot’s actual command signature.
Right now the instructions say “use the /fiatsent command”, but /help documents /fiatsent <_order id_> while other copy shows /fiatsent without an id (e.g., fiatsent_order_cmd: /fiatsent). If the handler requires an id, this line should say /fiatsent ${orderId} (or explicitly mention selecting the order in-chat).

82-88: Wording is still ambiguous (“add the parameter 0 indicating sats amount”).
Consider tightening to “add 0 as the sats amount” and split the sentence for readability.
-  In order to create a sale with a surplus in the price of 3% $premium$ you need to add the parameter 0 indicating sats amount\. The bot will calculate the selling price using the Bitcoin market price and applying the indicated surplus, you need to add 3 as the last parameter
+  To create a sale with a 3% premium, set the sats amount to 0\. The bot will calculate the sats amount from the market price and apply the premium\. Then add 3 as the last parameter\.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 875ede4 and a1fe355.

📒 Files selected for processing (1)

locales/en.yaml (4 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-10-22T14:03:55.114Z
Learning: Applies to {bot/**,locales/*.json} : Pair new bot flows with corresponding text updates under locales/

📚 Learning: 2025-08-14T18:53:14.640Z

Learnt from: CR
Repo: lnp2pBot/bot PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-14T18:53:14.640Z
Learning: Follow the Lightning Network hold-invoice escrow flow for buy and sell orders as documented

Applied to files:

locales/en.yaml

locales/en.yaml

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Catrya · 2025-12-12T20:29:17Z

locales/en.yaml

  Proof of payment: ${paymentSecret}
 pending_payment_success: |
-  I have paid the lightning invoice for ${amount} satoshis, order ID: ${id}!
+  I have paid the lightning invoice for ${amount} satoshis, order ID: ${orderId}!


Hi @RamzArzFarsi Thanks for your first contribution!
Was there a specific reason for changing it to ${orderId}?
${id} was used because this template serves dual purposes, it handles both order payments (order._id) and community payments (community.id).
Just want to make sure we maintain compatibility with both use cases.

I noticed the order ID placeholder was ${orderId} in the entire file except for this one particular place. I assumed it must be a typo.

is not a typo

I changed it back.

RamzArzFarsi · 2025-12-13T10:15:36Z

locales/fa.yaml

The old Persian file had weird phrasings and felt like a draft LLM translation.
This is a more refined and natural-sounding translation done manually (no LLM was used).

Catrya · 2025-12-15T22:55:43Z

locales/fa.yaml


-  `/buy 1000 50000 IRT "پرداخت با عابربانک"`
+  `/sell 1000 300000 IRT "کارت به کارت"`


should be /buy, not sell

Catrya

Hi @RamzArzFarsi , it won't compile; there are errors with the location keys. This is what appears when trying to compile:

[2025-12-15T16:52:25.134-06:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:62)

  7 |  ... 
  8 |  ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
  9 |  ... 
 10 |  ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
 11 |  ... 
 12 |  ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

RamzArzFarsi · 2025-12-16T10:13:15Z

Hi @RamzArzFarsi , it won't compile; there are errors with the location keys. This is what appears when trying to compile:

[2025-12-15T16:52:25.134-06:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:62)

  7 |  ... 
  8 |  ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
  9 |  ... 
 10 |  ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
 11 |  ... 
 12 |  ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

The compiling error should be gone now. Please try again and let me know if there are any more errors.

Luquitasjeffrey

Hi @RamzArzFarsi, I pulled your pr on my local and I'm still getting the same error:

[2025-12-17T18:40:51.873-03:00] error: Unhandled Rejection: YAMLException: can not read a block mapping entry; a multiline key may not be an implicit key (10:64)

7 | ...
8 | ... ‌های پایاپای بیت‌کوین روی شبکه لایتنینگ کمک می‌کند.
9 | ...
10 | ... د از دستورهای زیر استفاده کنید:
-----------------------------------------^
11 | ...
12 | ... ستورهای /buy (خرید) یا /sell (فروش) منتشر کنید و از دستورالعم ...

Please fix your syntax in the fa.yaml file so we can proceed with your pr.
Thanks

Catrya

As @Luquitasjeffrey said, it still doesn't work
The bot compiles but crashes on startup due to YAML syntax errors in fa.yaml. The translation file has invalid formatting that prevents the bot from starting. This needs to be fixed.

Updated Persian translations for disclaimer and instructions.

Corrected pluralization in Persian translations for various terms.

Luquitasjeffrey

Now your pr is Ok. It can be merged to the main branch

RamzArzFarsi · 2025-12-24T23:04:45Z

Please merge the PR if no further action is needed from my side.
And happy holidays to you. 🙂

knocte · 2026-01-03T02:01:57Z

@RamzArzFarsi can you please edit PR title and description to have something that makes sense there?

RamzArzFarsi · 2026-01-06T09:29:33Z

The PR is renamed.

knocte · 2026-01-06T09:36:30Z

Please replace the "Summary by CodeRabbit" with something that actually applies.

knocte · 2026-01-06T09:37:47Z

@aarani can you review?

Luquitasjeffrey · 2026-01-14T22:48:15Z

Hi @RamzArzFarsi. Please solve your conflicts with the main branch so we can proceed reviewing and merging this pr

Luquitasjeffrey

Please fix your conflicts with main so we can proceed merging your pr

grunch · 2026-01-23T18:47:22Z

@RamzArzFarsi can you please fix the conflicts and rebase?

RamzArzFarsi · 2026-02-04T16:47:03Z

I apologise for the delay. The recent events in Iran suddenly made me extremely busy. Thank you for your patience and understanding.

en.yaml

a1fe355

coderabbitai bot reviewed Dec 12, 2025

View reviewed changes

locales/en.yaml Outdated Show resolved Hide resolved

Update locales/en.yaml

fc4eda7

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Catrya reviewed Dec 12, 2025

View reviewed changes

RamzArzFarsi added 2 commits December 12, 2025 23:31

Update en.yaml

e2bb329

fa.yaml

0bf1e25

RamzArzFarsi commented Dec 13, 2025

View reviewed changes

Catrya reviewed Dec 15, 2025

View reviewed changes

Catrya requested changes Dec 15, 2025

View reviewed changes

RamzArzFarsi added 2 commits December 16, 2025 10:47

Update fa.yaml

36c8b9f

Update fa.yaml

4b4712d

RamzArzFarsi requested a review from Catrya December 16, 2025 10:13

Luquitasjeffrey requested changes Dec 17, 2025

View reviewed changes

Catrya reviewed Dec 20, 2025

View reviewed changes

RamzArzFarsi added 6 commits December 20, 2025 12:31

FA

6934d9d

FA

fc7a190

FA

0016b63

FA

55e584b

Updated Persian translations for disclaimer and instructions.

FA

7216f1d

FA

c4e92ac

RamzArzFarsi requested review from Catrya and Luquitasjeffrey December 20, 2025 13:42

RamzArzFarsi added 2 commits December 20, 2025 20:36

FA

1c1d4fd

FA

281054b

Corrected pluralization in Persian translations for various terms.

Luquitasjeffrey approved these changes Dec 22, 2025

View reviewed changes

Merge branch 'lnp2pBot:main' into main

23c58ca

RamzArzFarsi changed the title ~~en.yaml~~ A complete Persian (FA) translation and some minor corrections in the English file Jan 6, 2026

RamzArzFarsi requested a review from Luquitasjeffrey January 11, 2026 10:36

Luquitasjeffrey approved these changes Jan 22, 2026

View reviewed changes

Luquitasjeffrey requested changes Jan 22, 2026

View reviewed changes

Merge branch 'main' into main

3691eb4

RamzArzFarsi requested a review from Luquitasjeffrey February 4, 2026 16:47


		`/buy 1000 50000 IRT "پرداخت با عابربانک"`
		`/sell 1000 300000 IRT "کارت به کارت"`

A complete Persian (FA) translation and some minor corrections in the English file #711

Are you sure you want to change the base?

A complete Persian (FA) translation and some minor corrections in the English file #711

Conversation

RamzArzFarsi commented Dec 12, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Catrya Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 13, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi commented Dec 16, 2025

Uh oh!

Luquitasjeffrey left a comment

Choose a reason for hiding this comment

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

Luquitasjeffrey left a comment

Choose a reason for hiding this comment

Uh oh!

RamzArzFarsi commented Dec 24, 2025

Uh oh!

knocte commented Jan 3, 2026

Uh oh!

RamzArzFarsi commented Jan 6, 2026

Uh oh!

knocte commented Jan 6, 2026

Uh oh!

knocte commented Jan 6, 2026

Uh oh!

Luquitasjeffrey commented Jan 14, 2026

Uh oh!

Luquitasjeffrey left a comment

Choose a reason for hiding this comment

Uh oh!

grunch commented Jan 23, 2026

Uh oh!

RamzArzFarsi commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

RamzArzFarsi commented Dec 12, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 12, 2025 •

edited

Loading