Open
Conversation
gausie
reviewed
May 17, 2025
| * @returns Whether the supplied property should be coerced into a QuestStep | ||
| */ | ||
| export function isQuestProperty(property: string): boolean { | ||
| return property.startsWith("quest") || underscoredQuests.includes(property); |
Contributor
There was a problem hiding this comment.
Why not do || starts with _quest?
Contributor
Author
There was a problem hiding this comment.
Most prefs that start with _quest are not quest prefs.
Contributor
Author
|
Because of all of the NEP quest prefs that start with `_quest` that aren't
the quest
…On Sat, May 17, 2025, 2:38 AM Samuel Gaus ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/parseDefaultProperties.ts
<#797 (comment)>:
> @@ -140,6 +140,15 @@ export function isItemProperty(property: string): boolean {
);
}
+const underscoredQuests = ["_questPartyFair", "_questPirateRealm"]; // Most prefs that start with _quest are not quests
+/**
+ * @param property Property name
+ * @returns Whether the supplied property should be coerced into a QuestStep
+ */
+export function isQuestProperty(property: string): boolean {
+ return property.startsWith("quest") || underscoredQuests.includes(property);
Why not do || starts with _quest?
—
Reply to this email directly, view it on GitHub
<#797 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASZNQVPK3CZW3VMV5Y4ULP3263KORAVCNFSM6AAAAAB5J2XILWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNBYGA3TQMJVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.