Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds optional color support to the lob_print function, allowing console output to be printed in red, green, or yellow colors. The implementation includes Windows ANSI escape sequence support for Windows 10+ and gracefully falls back to non-colored output when colors are not supported.
Key Changes:
- Added
enable_windows_ansi_support()function to enable ANSI escape sequences on Windows - Implemented
_print_color()static method to handle colored printing with ANSI codes - Modified
lob_print()to use the new colored printing functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/lob_hlpr/hlpr.py | Added color printing support with Windows ANSI handling and new _print_color() method |
| tests/test_lob_hlpr.py | Added test cases for red, yellow, green, and unsupported color values |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This allows an optional kwarg color when printing. It does not need any dependencies and should fallback safely.
MrKevinWeiss
force-pushed
the
pr/addcolor
branch
from
5b3a4af to
a6c469b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an optional kwarg color when printing. It does not need any dependencies and should fallback safely.