Add DOCKER_FLAGS support for passing extra flags to the emulator container#248
Draft
anisaoshafi wants to merge 2 commits into
Draft
Add DOCKER_FLAGS support for passing extra flags to the emulator container#248anisaoshafi wants to merge 2 commits into
anisaoshafi wants to merge 2 commits into
Conversation
anisaoshafi
force-pushed
the
devx-852-lstk-ignores-docker_flags-for-emulators
branch
3 times, most recently
from
955e9e7 to
137a692
Compare
anisaoshafi
force-pushed
the
devx-852-lstk-ignores-docker_flags-for-emulators
branch
3 times, most recently
from
7066166 to
e44cfd4
Compare
anisaoshafi
force-pushed
the
devx-852-lstk-ignores-docker_flags-for-emulators
branch
from
e44cfd4 to
8b87446
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lstk had no way to pass arbitrary Docker flags when starting an emulator if you needed to inject environment variables (-e SERVICES=s3,sqs), or extra volume mounts.
The root cause was structural:
runtime.ContainerConfigonly modeled the options lstk explicitly needed (port bindings, known env vars, the volume mount for persistence).Fix
Added support for a
DOCKER_FLAGSenvironment variable and a docker_flags field in the[[containers]]config.toml block.Both accept a raw docker-run-style string (e.g. "-e SERVICES=s3,sqs -v /tmp/data:/data").
The two sources are merged: env var flags apply globally across all containers, config flags apply per-container.
Supported flags:
-e/--env, -v/--volume.