Conversation
|
@ieedan is attempting to deploy a commit to the Lochie's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Fixed the props! |
|
My bad forgot to bump vite along with it. Also removed some unnecessary config from the vite.config since we are using the workspace protocol we don't need that. |
|
@ieedan is this building locally for you? im seeing this error Caution error during build: |
|
Yeah it was building locally |
|
Okay was able to reproduce in my own Vercel deployment I guess that vite config is necessary after all. Weird I have never run into that before. In any case it should work now! |
|
I assumed Svelte 4 was an intentional choice for backwards compatibility, given Svelte 5 can use Svelte 4 components, but not vice-versa. Was that not the case @lochie ? EDIT: Apologies I skipped past the PR description here 😅 Agree I don't think it really matters all things considered, most libraries are starting to cut over to 5 now. I'm happy to look into it tomorrow if backwards-compatibility is desired. I'm assuming it's just some weird compilation issue with tsup causing Svelte code being compiled somewhere it shouldn't be. |
@jaydenfyi i dont personally use svelte so im not aware of the desires of the ecosystem. im happy to roll with whatever you two unanimously are happy with! |
|
@ieedan this PR looks good to me. but keen to understand the ideal scenario here re: 4 <> 5 support |
|
Svelte 4 should provide cross compatibility but the reason I raised this PR is that unfortunately at this time does not and Svelte 5 is broken. Since you can technically use Svelte 4 and 5 together in the same app I don't see any reason to support Svelte 4 at the expense of Svelte 5. Consumers can simply update their Svelte version at any time to use this library. |
Currently trying to use this in Svelte 5 doesn't work because of the following error:
Since this package is fairly new I can't imagine a whole lot of Svelte 4 users are using it yet so it seems fine to introduce a breaking change to support Svelte 5 instead.
Also updated the svelte-example and usage on the site.
Fixes #18