Skip to content

fix: macOS universal2 build, remove ARM64 for Linux/Windows #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahflee merged 1 commit into from
Feb 2, 2026
Merged

fix: macOS universal2 build, remove ARM64 for Linux/Windows #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 12 additions & 58 deletions .github/workflows/lockdown_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,35 +43,6 @@ jobs:
path: src/node/build/
retention-days: 1

build_linux_arm64:
name: Build Linux ARM64
runs-on: ubuntu-22.04-arm64-4-cores

steps:
- uses: actions/checkout@v4

- name: Install dependencies
run: |
sudo apt-get update
sudo apt-get install -y protobuf-compiler libpulse-dev cmake build-essential

- uses: actions/setup-node@v4
with:
node-version-file: "src/node/.nvmrc"

- name: Fetch WebRTC artifact
run: ./bin/fetch-artifact --platform linux-arm64 --release

- name: Build RingRTC
run: TARGET_ARCH=arm64 ./bin/build-desktop --ringrtc-only --release

- name: Upload build artifacts
uses: actions/upload-artifact@v4
with:
name: build-linux-arm64
path: src/node/build/
retention-days: 1

build_macos:
name: Build macOS (x64 + ARM64)
runs-on: macos-14
Expand All @@ -80,7 +51,11 @@ jobs:
- uses: actions/checkout@v4

- name: Install dependencies
run: brew install protobuf cmake
run: brew install protobuf coreutils

- name: Install Rust with cross-compile targets
run: |
rustup toolchain install $(cat rust-toolchain) --profile minimal --target x86_64-apple-darwin,aarch64-apple-darwin

- uses: actions/setup-node@v4
with:
Expand All @@ -91,14 +66,14 @@ jobs:
run: ./bin/fetch-artifact --platform mac-x64 --release

- name: Build RingRTC (x64)
run: TARGET_ARCH=x64 ./bin/build-desktop --ringrtc-only --release
run: TARGET_ARCH=x64 OUTPUT_DIR=out ./bin/build-desktop --ringrtc-only --release

# Build ARM64
- name: Fetch WebRTC artifact (ARM64)
run: ./bin/fetch-artifact --platform mac-arm64 --release -o out-arm

- name: Build RingRTC (ARM64)
run: OUTPUT_DIR=out-arm TARGET_ARCH=arm64 ./bin/build-desktop --ringrtc-only --release
run: TARGET_ARCH=arm64 OUTPUT_DIR=out-arm ./bin/build-desktop --ringrtc-only --release

- name: Upload build artifacts
uses: actions/upload-artifact@v4
Expand All @@ -108,16 +83,14 @@ jobs:
retention-days: 1

build_windows:
name: Build Windows (x64 + ARM64)
name: Build Windows x64
runs-on: windows-2022

steps:
- uses: actions/checkout@v4

- name: Install Rust
run: |
rustup toolchain install stable --profile minimal
rustup target add aarch64-pc-windows-msvc
run: rustup toolchain install stable --profile minimal

- name: Install protoc
run: choco install protoc
Expand All @@ -127,23 +100,10 @@ jobs:
with:
node-version-file: "src/node/.nvmrc"

# Build x64
- name: Fetch WebRTC artifact (x64)
- name: Fetch WebRTC artifact
run: sh ./bin/fetch-artifact --platform windows-x64 --release

- name: Build RingRTC (x64)
run: sh ./bin/build-desktop --ringrtc-only --release

# Build ARM64
- name: Fetch WebRTC artifact (ARM64)
run: sh ./bin/fetch-artifact --platform windows-arm64 --release -o out-arm

- name: Build RingRTC (ARM64)
run: |
echo "TARGET_ARCH=arm64" >> $env:GITHUB_ENV
echo "OUTPUT_DIR=out-arm" >> $env:GITHUB_ENV

- name: Build RingRTC (ARM64) - continued
- name: Build RingRTC
run: sh ./bin/build-desktop --ringrtc-only --release

- name: Upload build artifacts
Expand All @@ -155,7 +115,7 @@ jobs:

publish:
name: Publish to npm
needs: [build_linux_x64, build_linux_arm64, build_macos, build_windows]
needs: [build_linux_x64, build_macos, build_windows]
runs-on: ubuntu-latest

permissions:
Expand All @@ -176,12 +136,6 @@ jobs:
name: build-linux-x64
path: src/node/build/

- name: Download Linux ARM64 build
uses: actions/download-artifact@v4
with:
name: build-linux-arm64
path: src/node/build/

- name: Download macOS build
uses: actions/download-artifact@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions src/node/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lockdown-systems/ringrtc",
"version": "2.63.0-audiosink.1",
"version": "2.63.0-audiosink.2",
"repository": {
"type": "git",
"url": "https://github.com/lockdown-systems/ringrtc.git",
Expand Down
Loading