feat(website): Persist previous file uploads when revising submissions#6694
Draft
tombch wants to merge 25 commits into
Draft
feat(website): Persist previous file uploads when revising submissions#6694tombch wants to merge 25 commits into
tombch wants to merge 25 commits into
Conversation
…with discard files and accessing default files
…h discard all files not working for revisions
Contributor
|
This PR may be related to: #5820 (Revise in bulk reusing existing files) |
…no previous files exist in edit case
…d added comment detailing re-keying
…dit page: if we had an empty file mapping, keyed on submission id, this would display the folder upload. files would then be added, but keyed to dummy submission id. at submit time, the 'first' item in the map was accessed - the empty submission id map. I've decided to update the component to include an optional formSubmissionId, as in the edit/revise case we have the submission id already. this removes the possibility of having a mix of real id and dummy in the single edit/revise case which IMO was a bit of a footgun
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #5819 and #5829
Screenshot
PR Checklist
🚀 Preview: Add
previewlabel to enable