Skip to content

fix(backend): scope current pipeline etag tracker by organism#6716

Open
clonder wants to merge 2 commits into
mainfrom
fix/backend-current-pipeline-etag
Open

fix(backend): scope current pipeline etag tracker by organism#6716
clonder wants to merge 2 commits into
mainfrom
fix/backend-current-pipeline-etag

Conversation

@clonder

@clonder clonder commented Jun 18, 2026

Copy link
Copy Markdown

Fixes released-data ETag invalidation for current_processing_pipeline.

Pipeline changes for one organism no longer invalidate released-data cache checks for other organisms.

Fixes #6698 and related to #5110

🚀 Preview: Add preview label to enable

@clonder clonder requested a review from anna-parker June 18, 2026 21:49
@clonder clonder added bug Something isn't working backend related to the loculus backend component performance update_db_schema labels Jun 18, 2026
@anna-parker anna-parker requested a review from chaoran-chen June 19, 2026 07:35
@anna-parker anna-parker removed the bug Something isn't working label Jun 19, 2026
@theosanderson

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 5cf0327ad8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anna-parker anna-parker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Sorry for the delay in reviewing!

This isnt really necessary as we have tests and we have confirmed the tracker is working. But if you would like to get a feeling for how reprocessing works you could test this out on a preview and look into the grafana logs

  • add the preview label to the PR
  • Id recommend setting the preview db to persistent by adding developmentDatabasePersistence: true to your values.yaml
  • After all sequences are ingested on the preview doing a pipeline version bump for one organism e.g. ebola
  • Then you can confirm that there is no change in the etag of other organisms (you can see this best in the silo-import logs), they will show that if the etag changed or not:
Image

On Wednesday we can set up your kubeconfig so that you can portforward to preview databases as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend related to the loculus backend component performance update_db_schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add organism scoped trigger for current_preprocessing_pipeline to ensure etag isnt changed for other organisms on pipeline version update

4 participants