fix(backend): scope current pipeline etag tracker by organism#6716
fix(backend): scope current pipeline etag tracker by organism#6716clonder wants to merge 2 commits into
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anna-parker
left a comment
There was a problem hiding this comment.
Looks great! Sorry for the delay in reviewing!
This isnt really necessary as we have tests and we have confirmed the tracker is working. But if you would like to get a feeling for how reprocessing works you could test this out on a preview and look into the grafana logs
- add the
previewlabel to the PR - Id recommend setting the preview db to persistent by adding
developmentDatabasePersistence: trueto yourvalues.yaml - After all sequences are ingested on the preview doing a pipeline version bump for one organism e.g. ebola
- Then you can confirm that there is no change in the etag of other organisms (you can see this best in the silo-import logs), they will show that if the etag changed or not:
On Wednesday we can set up your kubeconfig so that you can portforward to preview databases as well :-)
Fixes released-data ETag invalidation for
current_processing_pipeline.Pipeline changes for one organism no longer invalidate released-data cache checks for other organisms.
Fixes #6698 and related to #5110
🚀 Preview: Add
previewlabel to enable