Transaction flows unification#484
Open
Pravdyvy wants to merge 10 commits into
Open
Conversation
Arjentix
approved these changes
May 20, 2026
Collaborator
Arjentix
left a comment
Arjentix
left a comment
There was a problem hiding this comment.
Cool refactoring, lgtm
moudyellaz
approved these changes
May 21, 2026
Collaborator
moudyellaz
left a comment
moudyellaz
left a comment
There was a problem hiding this comment.
lgtm, thanks. Left some minor comments.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Future LEZ core needs full transaction functionality. Unification of transaction management will help.
⚙️ Approach
Extending generic transaction creation to include public transactions. Added additional variant for
AccountManagerinputs to allow public accounts with forced no-sign.WalletCorenow have general methods to send public transactions as well.privacy_preserving_txintoaccount_managerto better explain its functionality.PrivacyPreservingAccountintoAccountManagerAccountIdentityto extend it for public executions.AccountManager. Public with forced no-sign.🧪 How to Test
Refactor, previous tests must pass.
🔗 Dependencies
None
🔜 Future Work
None
📋 PR Completion Checklist