feat: post issue comment when reviewer approves a plan#4
Open
Maxtanh-Meta wants to merge 1 commit into
Open
Conversation
Previously, the reviewer only posted a comment on rejection. This makes the approval path equally visible — operators and issue authors can see why the reviewer approved and that the gate was evaluated, without needing to check orchestrator logs.
Author
|
Author
Code Review (via Codex)Overall: ✅ Approve The change adds a best-effort GitHub comment on reviewer approval, matching the existing pattern for rejections. Codex found no correctness issues.
Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post an issue comment when the reviewer agent approves a plan, matching the existing behavior on rejection.
Before: Only rejections posted a comment (
[symphony-go] reviewer rejected the plan: ...). Approvals were only logged.After: Approvals also post a comment (
[symphony-go] ✅ reviewer approved the plan: ...), giving operators and issue authors visibility into the review decision without needing log access.Changes
internal/orchestrator/job.go: Add 3 lines to post approval reasons as an issue comment before proceeding to implementation.Testing
Tested end-to-end with a live repo — reviewer approval comment appears on the GitHub issue before implementation begins.