Skip to content

Increased use of log4j2 readability.#329

Open
fbacchella wants to merge 1 commit into
logstash-plugins:mainfrom
fbacchella:log_updates
Open

Increased use of log4j2 readability.#329
fbacchella wants to merge 1 commit into
logstash-plugins:mainfrom
fbacchella:log_updates

Conversation

@fbacchella

Copy link
Copy Markdown
Contributor

Added a log4j2.xml for tests runs.

Added a log4j2.xml for tests runs.

The plugin does not actually uses the log4j2 full power, and that make the code less readable.

@karmi

karmi commented Jun 21, 2018

Copy link
Copy Markdown

Hi @fbacchella, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@karmi

karmi commented Jun 21, 2018

Copy link
Copy Markdown

Hi @fbacchella, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@fbacchella

Copy link
Copy Markdown
Contributor Author

CLA signed.

@fbacchella

Copy link
Copy Markdown
Contributor Author

It needs PR #330 to work.

@robbavey robbavey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Java changes look great - a nice improvement. If you split out the changes to log4j.xml, I will merge this when the build goes green

Comment thread src/test/resources/log4j2.xml Outdated
Added a log4j2.xml for tests runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants