Open
Conversation
fixed to "tail" mode flags explanation instead "read" mode.
|
💚 CLA has been signed |
robbavey
reviewed
May 27, 2021
| read many content-complete files. Read mode now supports gzip file processing. | ||
|
|
||
| If `read` is specified, these settings can be used: | ||
| If `tail` is specified, these settings can be used: |
Member
There was a problem hiding this comment.
This isn't quite right - file_completed_action and file_completed_log_path are only relevant with read mode, but ignore_older works across both modes.
What this PR points out though, is that this section could do with some improvement in clarity as to which settings are used/ignored across the different modes. I've created an issue (#294) to track this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed to "tail" mode flags explanation instead "read" mode.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/