Skip to content

Fix compatibility with PHP 8.0 beta4#46

Merged
longxinH merged 1 commit into
longxinH:masterfrom
skilld-labs:beta4
Sep 18, 2020
Merged

Fix compatibility with PHP 8.0 beta4#46
longxinH merged 1 commit into
longxinH:masterfrom
skilld-labs:beta4

Conversation

@andypost

Copy link
Copy Markdown

It got change again https://github.com/php/php-src/blob/master/Zend/zend_compile.c#L82

I found no other changes

@andypost

Copy link
Copy Markdown
Author

More changes could could cause already accepted php/php-src#5857

sounds like it needs separate issue

PS https://derickrethans.nl/phpinternalsnews-68.html

@longxinH

Copy link
Copy Markdown
Owner

It seems to be processing an observer separately

@longxinH longxinH merged commit d3d0dc4 into longxinH:master Sep 18, 2020
@andypost andypost deleted the beta4 branch September 18, 2020 17:36
@andypost

Copy link
Copy Markdown
Author

Observer looks still in progress of clean-up

@longxinH please create a beta release to allow build it via pecl

@longxinH

longxinH commented Sep 19, 2020

Copy link
Copy Markdown
Owner

Thank you very much, it has been posted to pecl

@andypost

Copy link
Copy Markdown
Author

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants