fix: enable inq filters for referancesMany relations#783
Open
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Open
fix: enable inq filters for referancesMany relations#783aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
aaqilniz wants to merge 1 commit intoloopbackio:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Pull Request Test Coverage Report for Build 17603913986Details
💛 - Coveralls |
aaqilniz
force-pushed
the
fix/enable-inq-refmany
branch
2 times, most recently
from
84723f3 to
9d6077c
Compare
aaqilniz
force-pushed
the
fix/enable-inq-refmany
branch
from
9d6077c to
77eccac
Compare
This was referenced Sep 6, 2025
Open
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
fix/enable-inq-refmany
branch
from
77eccac to
72397d5
Compare
samarpanB
requested changes
Nov 17, 2025
| SQLConnector.prototype.buildWhere = function(model, where, options) { | ||
| let relationType = ''; | ||
| let relationKeyFrom = ''; | ||
| if (options && options['model'] && options['model']['definition']) { |
Contributor
There was a problem hiding this comment.
Ideally this should be part of datasource juggler repo as thats where we implement relations.
Contributor
Author
There was a problem hiding this comment.
Hi, @samarpanB. The relations are defined in the datasource-juggler, but here I am trying to modify the SQL queries to enable the inq filter for referencesMany relations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inq filter fails in referencesMany relations. This PR fixes that.
Related PR@loopback-next
Checklist
npm testpasses on your machine