Open
Conversation
Contributor
vitalyster
commented
Jan 4, 2019
vitalyster
commented
- Fixes Error during compilation #1263
Member
|
Sorry, this doesn't work for me in all LTS versions. Anyone else can test it? |
Contributor
Author
|
Which error you have? |
Contributor
Author
|
I did add Travis CI configuration and everything works with node 11, 10 and 8 - https://travis-ci.org/vitalyster/im/builds/476013924 |
Member
|
Well, it's not directly an error, but some problems with vulnerabilities (4 high), same as in tarvis log. |
Member
|
There's also a problem with the Renderer. A built app doesn't start on UT, because the Renderes class in blaze.js is missing. |
Contributor
Author
|
Vulnerable packages are dependencies of grunt-nw-builder, grunt-debian-package, etc, these packages does not look maintained but they are only devDependencies so vulnerable 'minimatch' package should not be ship with app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.