(Issue #119) Remove return value from reinit screen#129
Open
lucas-james wants to merge 3 commits intolordmauve:mainfrom
Open
(Issue #119) Remove return value from reinit screen#129lucas-james wants to merge 3 commits intolordmauve:mainfrom
lucas-james wants to merge 3 commits intolordmauve:mainfrom
Conversation
Moving the logic for need_redraw to more relevant places
lordmauve
reviewed
Oct 3, 2018
| if key == keys.SPACE and not game.player.frozen and not is_paused(): | ||
| sounds.fire.play() | ||
| game.bullets.append(game.player.fire()) | ||
| if key == keys.RETURN: |
Owner
There was a problem hiding this comment.
Return is an odd choice for a pause key. Perhaps P instead of return?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the following issue: 9afb94d
Based on the work in the following branch:
#123
the reinit_screen function actually no longer needs a return value (only the last commit here adds anything) 👍