Implemented programmatic option selection#40
Open
Tijunel wants to merge 1 commit intolorensr:masterfrom
Open
Conversation
lorensr
requested changes
Mar 5, 2021
Owner
lorensr
left a comment
lorensr
left a comment
There was a problem hiding this comment.
Thanks! Could you add test cases to src/stores?
| const exists = this.props.options.find( | ||
| (el) => el.value === this.props.selectedValue | ||
| ) | ||
| if (exists) return true |
Owner
There was a problem hiding this comment.
I'd replace this line with return exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have tested with stories and my own usage and have no problems, did my best to keep the code simple but this took a bit of tinkering. Added a bit of documentation that I think should be sufficient. Hopefully this is good :)