Initial commit with Boolean and Enum implementation#33
Initial commit with Boolean and Enum implementation#33abhishek130904 wants to merge 1 commit intolow-rb:mainfrom
Conversation
|
Thank you for this PR. There are a few people interested in this issue via GSoC and it will take a while to sort through the solutions and apply the most suitable one. I have a few proposals via GSoC, including a strong proposal, so I will have to get all of the solutions in my head at once somehow :) Your contribution is appreciated and I will read it and provide feedback |
| class << self | ||
| def type?(expression) | ||
| basic_type?(expression:) || complex_type?(expression:) | ||
| basic_type?(expression:) || complex_type?(expression:) || enum_definition?(expression:) |
There was a problem hiding this comment.
I think the enum could be considered a complex type and the detection logic could be done in complex_type?(expression:) instead
|
|
||
| require_relative '../../lib/low_type' | ||
|
|
||
| class BooleanAndEnum |
There was a problem hiding this comment.
It's better for long term maintainability and understanding to split these out into separate fixture files, as they are not really related features, just being built at the same time
2 participants
Summary
This PR adds support for Boolean and Enum types in LowType.
Changes
Boolean
Enum
Core Integration
Tests
Motivation
Notes