Merged
Conversation
Add buffer map_read/write Add copy texture to buffer Add method to copy texture to cpu
voxelias
requested changes
Apr 19, 2022
Member
voxelias
left a comment
There was a problem hiding this comment.
Just couple questions, and I believe TextureKind should be re-implemented with native WGPU enum,
voxelias
approved these changes
Apr 20, 2022
Member
voxelias
left a comment
There was a problem hiding this comment.
Thank you very much! This part was really wanted!
Contributor
Author
|
Awesome, glad to help. I'll work these changes into my voxels and get materials working with it. I'll see about adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds features from #152 that I am adding here to make the PRs more modular
Specifically: