Conversation
Bumps the bundler group with 1 update in the / directory: [devise](https://github.com/heartcombo/devise). Updates `devise` from 4.9.4 to 5.0.3 - [Release notes](https://github.com/heartcombo/devise/releases) - [Changelog](https://github.com/heartcombo/devise/blob/main/CHANGELOG.md) - [Commits](heartcombo/devise@v4.9.4...v5.0.3) --- updated-dependencies: - dependency-name: devise dependency-version: 5.0.3 dependency-type: direct:production dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com>
…pecs for subscription scenarios Update the ActiveAdmin application registration to include subscription costs in total cost calculations. Introduce a new request spec to validate the correct computation of total costs and balance due for applications with and without subscriptions, ensuring accurate display in the admin interface.
…7070 Bump devise from 4.9.4 to 5.0.3 in the bundler group across 1 directory
…ler-bd7d227070 Revert "Bump devise from 4.9.4 to 5.0.3 in the bundler group across 1 directory"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates how the total cost and balance due are calculated for applications in the admin interface, ensuring that subscription costs are properly included when applicable. It also adds comprehensive request specs to verify these calculations both with and without a subscription. Additionally, it improves the conference year filter in the admin applications list.
Cost calculation improvements:
Admin interface enhancements:
applications_conf_yearfilter in the admin applications list now shows only distinct, ordered conference years from existing applications, making it more user-friendly and accurate.Testing improvements:
spec/requests/admin_applications_show_spec.rb) that verifies the correctness of total cost and balance due calculations on the admin application show page, covering both scenarios: with and without a subscription.